[
https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019465#comment-13019465
]
Uwe Schindler commented on SOLR-2436:
-------------------------------------
I just looked at the patch, is the SOLR-2436_2.patch still active or replaced
by Kojis?
I ask because:
{noformat}
+ try{
+ final InputSource is = new
InputSource(loader.openConfig(uimaConfigFile));
+ DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
+ // only enable xinclude, if SystemId is present (makes no sense
otherwise)
+ if (is.getSystemId() != null) {
+ try {
+ dbf.setXIncludeAware(true);
+ dbf.setNamespaceAware(true);
+ } catch( UnsupportedOperationException e ) {
+ LOG.warn( "XML parser doesn't support XInclude option" );
+ }
+ }
{noformat}
This XInclude Handling is broken (the if-clause never gets executed). We have a
new framework that makes XML-Loading from ResourceLoaders working correct, even
with relative pathes! Just look at the example committed during the cleanup
issue (look at other places in solr where DocumentBuilders or XMLStreamReaders
are instantiated. The new Solr way to load such files is a special URI scheme
that is internally used to resolve ResourceLoader resources correctly (see
SOLR-1656).
The latest patch looks fine, it embeds the config directly, which seems much
more consistent.
> move uimaConfig to under the uima's update processor in solrconfig.xml
> ----------------------------------------------------------------------
>
> Key: SOLR-2436
> URL: https://issues.apache.org/jira/browse/SOLR-2436
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Koji Sekiguchi
> Priority: Minor
> Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch,
> SOLR-2436.patch, SOLR-2436_2.patch
>
>
> Solr contrib UIMA has its config just beneath <config>. I think it should
> move to uima's update processor tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
