[
https://issues.apache.org/jira/browse/SOLR-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391501#comment-15391501
]
Christine Poerschke commented on SOLR-9331:
-------------------------------------------
Thanks [~joel.bernstein] for the QueryResultCache and getDocListNC pointers. I
now realize why and agree that the length passed to the constructor and the len
passed to getTopDocsCollector are potentially different and so the
constructor's length argument should stay therefore. Whilst looking at the code
I noticed that the hashCode and equalsTo in ReRankQuery don't use the length
member, SOLR-9336 created with proposed patch to change that - what do you
think?
> Can we remove ReRankQuery's length constructor argument?
> --------------------------------------------------------
>
> Key: SOLR-9331
> URL: https://issues.apache.org/jira/browse/SOLR-9331
> Project: Solr
> Issue Type: Wish
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-9331.patch
>
>
> Can we remove ReRankQuery's length constructor argument? It is a
> ReRankQParserPlugin private class.
> proposed patch summary:
> * change ReRankQuery.getTopDocsCollector to use its len argument (instead of
> the length member)
> * remove ReRankQuery's length member and constructor argument
> * remove ReRankQParser.parse's use of the rows and start parameters
> motivation: towards ReRankQParserPlugin and LTRQParserPlugin (SOLR-8542)
> sharing (more) code
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
