[
https://issues.apache.org/jira/browse/SOLR-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409357#comment-15409357
]
Christine Poerschke commented on SOLR-9331:
-------------------------------------------
Hi [~joel.bernstein] - no problem. Thanks for your input on my re-ranker small
refactor work. My plan is to commit SOLR-9353 later this afternoon and then
this SOLR-9331 here Monday or Tuesday. Would that work for you too? From quick
look at the latest SOLR-9252 patch there should be no merge conflicts.
> Can we remove ReRankQuery's length constructor argument?
> --------------------------------------------------------
>
> Key: SOLR-9331
> URL: https://issues.apache.org/jira/browse/SOLR-9331
> Project: Solr
> Issue Type: Wish
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-9331.patch
>
>
> Can we remove ReRankQuery's length constructor argument? It is a
> ReRankQParserPlugin private class.
> proposed patch summary:
> * change ReRankQuery.getTopDocsCollector to use its len argument (instead of
> the length member)
> * remove ReRankQuery's length member and constructor argument
> * remove ReRankQParser.parse's use of the rows and start parameters
> motivation: towards ReRankQParserPlugin and LTRQParserPlugin (SOLR-8542)
> sharing (more) code
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
