[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448302#comment-15448302
]
Uwe Schindler commented on SOLR-9444:
-------------------------------------
Hi,
this looks cool! I will try it out in a minute on my windows with whitespace in
path.
This looks exactly as I proposed:
- Only pass URI instances around instead of strings
- Change createURI to take the base URI as URI
- Add a new createURI that takes a single string and is responsible to create
aplain RI from a string, which is repository specific
Maybe rename the createURI that takes a baseURI and componenets to have a
different name? E.g. resolveURI?
> Fix path usage for cloud backup/restore
> ---------------------------------------
>
> Key: SOLR-9444
> URL: https://issues.apache.org/jira/browse/SOLR-9444
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Attachments: SOLR-9444.patch
>
>
> As noted by Uwe on
> https://issues.apache.org/jira/browse/SOLR-9242?focusedCommentId=15438925&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15438925
> the usage of URI#getPath is wrong.
> Creating a Jira to track this better. More details to follow
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
