[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457741#comment-15457741
]
ASF GitHub Bot commented on SOLR-9444:
--------------------------------------
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/74#discussion_r77301896
--- Diff:
solr/core/src/test/org/apache/solr/cloud/TestLocalFSCloudBackupRestore.java ---
@@ -24,12 +24,20 @@
* such file-system would be exposed via local file-system API.
*/
public class TestLocalFSCloudBackupRestore extends
AbstractCloudBackupRestoreTestCase {
+ private static String backupLocation;
@BeforeClass
public static void setupClass() throws Exception {
configureCluster(NUM_SHARDS)// nodes
.addConfig("conf1",
TEST_PATH().resolve("configsets").resolve("cloud-minimal").resolve("conf"))
.configure();
+
+ boolean whitespacesInPath = random().nextBoolean();
+ if (whitespacesInPath) {
+ backupLocation = createTempDir("my
backup").toFile().getAbsolutePath();
--- End diff --
I'd use `backupLocation = createTempDir(...).toAbsolutePath().toString();`
to get rid of legacy `java.io.File`
> Fix path usage for cloud backup/restore
> ---------------------------------------
>
> Key: SOLR-9444
> URL: https://issues.apache.org/jira/browse/SOLR-9444
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Attachments: SOLR-9444.patch
>
>
> As noted by Uwe on
> https://issues.apache.org/jira/browse/SOLR-9242?focusedCommentId=15438925&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15438925
> the usage of URI#getPath is wrong.
> Creating a Jira to track this better. More details to follow
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
