[
https://issues.apache.org/jira/browse/LUCENE-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451738#comment-15451738
]
Uwe Schindler commented on LUCENE-7429:
---------------------------------------
I know why you did this, but it just looks wrong! IMHO, the whole
attributefactory as part of the ctor of Tokenizers is not really a good idea,
but some people like to have this! The AttributeFactory should be passed by the
ctor of the subclass of a Tokenizer to super, if a Tokenizer needs a special
one. But passing that around everywhere is not really useful.
> DelegatingAnalyzerWrapper should delegate normalization too
> -----------------------------------------------------------
>
> Key: LUCENE-7429
> URL: https://issues.apache.org/jira/browse/LUCENE-7429
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 6.2
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-7355.patch, LUCENE-7429.patch
>
>
> This is something that I overlooked in LUCENE-7355:
> (Delegating)AnalyzerWrapper uses the default implementation of
> initReaderForNormalization and normalize, meaning that by default the
> normalization is a no-op. It should delegate to the wrapped analyzer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
