[
https://issues.apache.org/jira/browse/LUCENE-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452873#comment-15452873
]
Uwe Schindler commented on LUCENE-7429:
---------------------------------------
Hi,
I'd suggest to use the previous patch. I don't like it to create (and consume)
a TokenStream just to get its attribute source. This may be heavy, although it
is unlikely for stuff that gets normalized.
The issue here is mostly that we need to create a new TokenStream
(StringTokenStream) for the normalization and we need to use the same attribute
types. Although this is sometimes broken for use-cases, where TokenStreams
create binary tokens. But those would never be normalized, I think (!?)
Uwe
> DelegatingAnalyzerWrapper should delegate normalization too
> -----------------------------------------------------------
>
> Key: LUCENE-7429
> URL: https://issues.apache.org/jira/browse/LUCENE-7429
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 6.2
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-7355.patch, LUCENE-7429.patch, LUCENE-7429.patch
>
>
> This is something that I overlooked in LUCENE-7355:
> (Delegating)AnalyzerWrapper uses the default implementation of
> initReaderForNormalization and normalize, meaning that by default the
> normalization is a no-op. It should delegate to the wrapped analyzer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
