[ 
https://issues.apache.org/jira/browse/SOLR-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Gerlowski updated SOLR-9535:
----------------------------------
    Attachment: SOLR-9535.patch

Attaching a patch making this change in CloudSolrClient.

After some poking around, HttpSolrClient, LBHttpSolrClient, and 
ConcurrentUpdateSolrClient all had a "catch-all" ctor marked as {{protected}} 
so this really turned into a single-line change.

> SolrClients should have protected constructors
> ----------------------------------------------
>
>                 Key: SOLR-9535
>                 URL: https://issues.apache.org/jira/browse/SOLR-9535
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrJ
>    Affects Versions: 6.x
>            Reporter: Jason Gerlowski
>            Priority: Minor
>             Fix For: 6.x
>
>         Attachments: SOLR-9535.patch
>
>
> Recent SolrJ changes (SOLR-8097) resulted in {{SolrClient}} ending up with 
> {{protected}} ctors.  This achieved the purpose at the time, and steered 
> consumers towards using the *Builder types.  However the change was overly 
> restrictive, as this visibility prevents consumers from extending 
> {{SolrClient}} in any meaningful way.
> This issue involves changing the visibility of the SolrClient "kitchen sink" 
> ctors to better support extension.
> (See recent discussion on SOLR-8097 for more discussion on this topic.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to