Dawid Weiss commented on LUCENE-7453:

bq. Are you fine to get docIndex from IndexReader or IndexSearcher after 
submitting docs to IndexWriter?

Yes, I think so. When you add a document to an IndexWriter you don't get any 
document "id" (or number) anyway. Documents are indexed and made available to 
you once you acquire a new IndexReader -- and then each document will be 
uniquely described with an "index", valid only within this particular 
IndexReader. I think this makes sense, even when you think of methods like 
{{maxDoc}} which could read {{maxDocIndex}}...

> Change naming of variables/apis from docid to docnum
> ----------------------------------------------------
>                 Key: LUCENE-7453
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7453
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Ryan Ernst
> In SOLR-9528 a suggestion was made to change {{docid}} to {{docnum}}. The 
> reasoning for this is most notably that {{docid}} has a connotation about a 
> persistent unique identifier (eg like {{_id}} in elasticsearch or {{id}} in 
> solr), while {{docid}} in lucene is currently some local to a segment, and 
> not comparable directly across segments.
> When I first started working on Lucene, I had this same confusion. {{docnum}} 
> is a much better name for this transient, segment local identifier for a doc. 
> Regardless of what solr wants to do in their api (eg keeping _docid_), I 
> think we should switch the lucene apis and variable names to use docnum.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to