[
https://issues.apache.org/jira/browse/SOLR-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516413#comment-15516413
]
Yonik Seeley commented on SOLR-6090:
------------------------------------
bq. I cannot find where this variable is set to true so the printLayout is
never actually printed.
Normally, stuff like this is set manually by someone trying to get more info
when trying to debug a failing test.
Here's another example: StoppableIndexingThread has a parameter called
doDeletes... but every case in the code base passes "true". But that doesn't
mean it's a useless parameter and should be removed. One of the first things I
do when trying to debug a Chaos* fail is to set that parameter to false and see
if the error happens with adds only. It simplifies debugging.
> Remove unreachable printLayout usage in cloud test
> --------------------------------------------------
>
> Key: SOLR-6090
> URL: https://issues.apache.org/jira/browse/SOLR-6090
> Project: Solr
> Issue Type: Task
> Components: SolrCloud, Tests
> Reporter: Shalin Shekhar Mangar
> Assignee: Cao Manh Dat
> Priority: Minor
> Fix For: 6.3, master (7.0)
>
> Attachments: SOLR-6090.patch
>
>
> Many cloud tests have a DEBUG instance variable e.g.
> {code}
> private static final boolean DEBUG = false;
> {code}
> and
> {code}
> if (DEBUG) {
> super.printLayout();
> }
> {code}
> I cannot find where this variable is set to true so the printLayout is never
> actually printed.
> We need to review and fix all such tests:
> # BasicDistributedZKTest.doTest
> # CollectionsAPIAsyncDistributedZkTest.doTest
> # CollectionsAPIDistributedZkTest
> # CustomCollectionTest
> # UnloadDistributedZkTest
> This is not an exhaustive list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
