[
https://issues.apache.org/jira/browse/SOLR-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516901#comment-15516901
]
Yonik Seeley commented on SOLR-6090:
------------------------------------
bq. Log it in debug level or add it when necessary
Perhaps better way to phase the summary in this issue would be "Should this be
hooked into a debugging level, or is it no longer useful and can be removed?"
bq. Anyway, if you want to keep it, feel free to revert my commit.
That debugging code wasn't mine and I've never used it.
I was more responding to the original reasoning for removal (that it was dead
code).
I guess there's a lot of context and judgement to these things though... for
example, is the person removing the code the person who wrote it? In that
case, it does feel like a trivial cleanup (prob no one else ever used it) and
wouldn't even warrant a JIRA IMO.
> Remove unreachable printLayout usage in cloud test
> --------------------------------------------------
>
> Key: SOLR-6090
> URL: https://issues.apache.org/jira/browse/SOLR-6090
> Project: Solr
> Issue Type: Task
> Components: SolrCloud, Tests
> Reporter: Shalin Shekhar Mangar
> Assignee: Cao Manh Dat
> Priority: Minor
> Fix For: 6.3, master (7.0)
>
> Attachments: SOLR-6090.patch
>
>
> Many cloud tests have a DEBUG instance variable e.g.
> {code}
> private static final boolean DEBUG = false;
> {code}
> and
> {code}
> if (DEBUG) {
> super.printLayout();
> }
> {code}
> I cannot find where this variable is set to true so the printLayout is never
> actually printed.
> We need to review and fix all such tests:
> # BasicDistributedZKTest.doTest
> # CollectionsAPIAsyncDistributedZkTest.doTest
> # CollectionsAPIDistributedZkTest
> # CustomCollectionTest
> # UnloadDistributedZkTest
> This is not an exhaustive list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
