Github user dsmiley commented on the pull request:
https://github.com/apache/lucene-solr/commit/a62fba7a4ebdf7b46b12ef017fc89816ae709935#commitcomment-19906717
In
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java:
In
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java on
line 60:
In my personal opinion, these 21 extra lines aren't worth the value they
bring in validating 2 possible values. But I know you have a different opinion
:-) You've already written it; it can stay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
