Github user dsmiley commented on the pull request:
https://github.com/apache/lucene-solr/commit/a62fba7a4ebdf7b46b12ef017fc89816ae709935#commitcomment-19906814
In
solr/core/src/test/org/apache/solr/highlight/TestUnifiedSolrHighlighter.java:
In
solr/core/src/test/org/apache/solr/highlight/TestUnifiedSolrHighlighter.java on
line 50:
Maybe I'm missing something, but I think this method could be a 1-liner in
which you use the overloaded version of `SolrTestCaseJ4.req(SolrParams params,
String... moreParams)`. If not then I'm sure you could avoid this array copying
low-level stuff by using the params() method and then simply set hl.method on
it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
