[ 
https://issues.apache.org/jira/browse/LUCENE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated LUCENE-3084:
----------------------------------

    Attachment: LUCENE-3084-trunk-only.patch

Here updated patch that removes some List<SI> usage from DirectoryReader and 
IndexWriter for rollback when commit fails. I am still not happy with 
interacting of IndexWriter code directly with the list, but this should maybe 
fixed later.

This patch could also be backported to cleanup 3.x, but for backwards 
compatibility, the SegmentInfos class should still extend Vector<SI>, but we 
can make the fields "segment" simply point to this. I am not sure how to 
"deprecated" extension of a class? A possibility would be to add each Vector 
method as a overridden one-liner and deprecated, but thats a non-brainer and 
stupid to do :(

> MergePolicy.OneMerge.segments should be List<SegmentInfo> not SegmentInfos
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3084
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3084
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3084-trunk-only.patch, 
> LUCENE-3084-trunk-only.patch, LUCENE-3084-trunk-only.patch, 
> LUCENE-3084-trunk-only.patch, LUCENE-3084.patch
>
>
> SegmentInfos carries a bunch of fields beyond the list of SI, but for merging 
> purposes these fields are unused.
> We should cutover to List<SI> instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to