[
https://issues.apache.org/jira/browse/LUCENE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035282#comment-13035282
]
Michael McCandless commented on LUCENE-3084:
--------------------------------------------
Looks awesome Uwe! +1 to commit. Some small variable naming
suggestions:
* Rename cloneChilds -> cloneChildren (sis.createBackupSIS)
* Maybe call it (and, invert) "mapIndexesValid" instead of
"mapIndexesInvalid" (in SIS.java)? I generally prefer not putting
not into boolean variables when possible, for sanity...
> MergePolicy.OneMerge.segments should be List<SegmentInfo> not SegmentInfos,
> Remove Vector<SI> subclassing from SegmentInfos & more refactoring
> ----------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3084
> URL: https://issues.apache.org/jira/browse/LUCENE-3084
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3084-trunk-only.patch,
> LUCENE-3084-trunk-only.patch, LUCENE-3084-trunk-only.patch,
> LUCENE-3084-trunk-only.patch, LUCENE-3084-trunk-only.patch,
> LUCENE-3084-trunk-only.patch, LUCENE-3084-trunk-only.patch,
> LUCENE-3084-trunk-only.patch, LUCENE-3084.patch
>
>
> SegmentInfos carries a bunch of fields beyond the list of SI, but for merging
> purposes these fields are unused.
> We should cutover to List<SI> instead.
> Also SegmentInfos subclasses Vector<SI>, this should be removed and the
> collections be hidden inside the class. We can add unmodifiable views on it
> (asList(), asSet()).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
