[ 
https://issues.apache.org/jira/browse/SOLR-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851364#comment-15851364
 ] 

Christine Poerschke commented on SOLR-9914:
-------------------------------------------

Java8 
[Predicate<T>|https://docs.oracle.com/javase/8/docs/api/java/util/function/Predicate.html]
 - hadn't come across that before, thanks for the pointer.

Yes, {{Predicate<BytesRef>}} seems very suitable for the job here and would 
also simplify the {{MultiBytesRefFilter}} implementation in the SOLR-9912 
parent task's patch.

Jonny - what do you think?

> SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-9914
>                 URL: https://issues.apache.org/jira/browse/SOLR-9914
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Jonny Marks
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-9914.patch
>
>
> This patch refactors the "contains" logic for only including constraints 
> which contain a given substring, into a "BytesRefMatcher" interface and 
> "SubstringBytesRefMatcher" implementation. 
> This allows users to have custom logic for including terms in the filter 
> counts, not only based on substring matches.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to