[
https://issues.apache.org/jira/browse/SOLR-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852605#comment-15852605
]
David Smiley commented on SOLR-9914:
------------------------------------
I don't think SimpleFacets.contains needs to stick around and be deprecated;
just outright delete it if there are no callers within the codebase.
Otherwise +1; this is a nice generalization.
> SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class
> -----------------------------------------------------------------------------
>
> Key: SOLR-9914
> URL: https://issues.apache.org/jira/browse/SOLR-9914
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Jonny Marks
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-9914.patch, SOLR-9914.patch
>
>
> This patch refactors the "contains" logic for only including constraints
> which contain a given substring, into a "BytesRefMatcher" interface and
> "SubstringBytesRefMatcher" implementation.
> This allows users to have custom logic for including terms in the filter
> counts, not only based on substring matches.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]