Github user dennisgove commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/126#discussion_r103494004
  
    --- Diff: solr/core/src/java/org/apache/solr/search/facet/SlotAcc.java ---
    @@ -394,7 +394,16 @@ public CountSlotAcc(FacetContext fcontext) {
       int[] result;
       public CountSlotArrAcc(FacetContext fcontext, int numSlots) {
         super(fcontext);
    -    result = new int[numSlots];
    +    
    +    String key = fcontext.level + this.getClass().getSimpleName();
    +    result = (int[]) fcontext.getReusable(key);
    +    if (result == null || result.length < numSlots) {
    +      result = new int[numSlots];
    +      fcontext.addReusable(key, result);
    --- End diff --
    
    If null != result is it reasonable to reset the value under the key to the 
newly created array?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to