[
https://issues.apache.org/jira/browse/SOLR-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959865#comment-15959865
]
Keith Laban commented on SOLR-10047:
------------------------------------
Shalin, based on your comment I did a bit of an overhaul to the original PR.
Instead of deleting UninvertingReader#wrap I changed the interface from
accepting {{Map}} to {{Function<LeafReader,Map>}}. With this change I updated
SolrIndexSearcher to use this interface instead of creating a new static class.
I also updated all of the places where the original static function {{wrap}}
was being used.
If you think updating all of the test to the new interface is too much
overkill/not backcompat I can overload the {{UninvertingReader#wrap}} function
to accept the original static mapping and delegate to the new impl.
> Mismatched Docvalue segments cause exception in Sorting/Facting; Uninvert per
> segment
> -------------------------------------------------------------------------------------
>
> Key: SOLR-10047
> URL: https://issues.apache.org/jira/browse/SOLR-10047
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Keith Laban
>
> The configuration of UninvertingReader in SolrIndexSearch creates a global
> mapping for the directory for fields to uninvert. If docvalues are enabled on
> a field the creation of a new segment will cause the query to fail when
> faceting/sorting on the recently docvalue enabled field. This happens because
> the UninvertingReader is configured globally across the entire directory, and
> a single segment containing DVs for a field will incorrectly indicate that
> all segments contain DVs.
> This patch addresses the incorrect behavior by determining the fields to be
> uninverted on a per-segment basis.
> With the fix, it is still recommended that a reindexing occur as data loss
> will when a DV and non-DV segment are merged, SOLR-10046 addresses this
> behavior. This fix is to be a stop gap for the time between enabling
> docvalues and the duration of a reindex.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
