[ 
https://issues.apache.org/jira/browse/SOLR-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964985#comment-15964985
 ] 

Keith Laban commented on SOLR-10047:
------------------------------------

Shalin, I wasn't sure exactly how you wanted me to submit the diff between 6.x 
and master.

In this PR:
- 
[Commit|https://github.com/kelaban/lucene-solr/commit/806f33e092491cc6a2ee292d2934c76171e40dc7]
 adds new and old interface, and modifies all the tests to use the new interface
- 
[Commit|https://github.com/kelaban/lucene-solr/commit/c38f4cabc2828ee83b53b931dd829e29a3e1701c]
 reverts the tests to using the old interface. 

If you want to keep both interfaces as a convenience method and tests 
unmodified you can squash them all down. Otherwise use HEAD for 6.x (tests not 
updated) and reset to HEAD^ for master (tests updated). 

I did not write specific tests to explicitly use new/old signature because they 
all use the new signature under the hood. The test I added in the original 
commit tests the updated intended behavior.

> Mismatched Docvalue segments cause exception in Sorting/Facting; Uninvert per 
> segment
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-10047
>                 URL: https://issues.apache.org/jira/browse/SOLR-10047
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Keith Laban
>
> The configuration of UninvertingReader in SolrIndexSearch creates a global 
> mapping for the directory for fields to uninvert. If docvalues are enabled on 
> a field the creation of a new segment will cause the query to fail when 
> faceting/sorting on the recently docvalue enabled field. This happens because 
> the UninvertingReader is configured globally across the entire directory, and 
> a single segment containing DVs for a field will incorrectly indicate that 
> all segments contain DVs.
> This patch addresses the incorrect behavior by determining the fields to be 
> uninverted on a per-segment basis.
> With the fix, it is still recommended that a reindexing occur as data loss 
> will when a DV and non-DV segment are merged, SOLR-10046 addresses this 
> behavior. This fix is to be a stop gap for the time between enabling 
> docvalues and the duration of a reindex. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to