[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974710#comment-15974710 ]
Adrien Grand commented on LUCENE-7788: -------------------------------------- It looks a bit fragile to me as it only catches cases when the logger is called {{log}} while Solr seems to have some loggers called {{LOG}}, {{logger}} or even {{requestLog}}? Also, should we remove the {{if (trace)}} from {{TransactionLog}} if we do that? > fail precommit on unparameterised log.trace messages > ---------------------------------------------------- > > Key: LUCENE-7788 > URL: https://issues.apache.org/jira/browse/LUCENE-7788 > Project: Lucene - Core > Issue Type: Task > Reporter: Christine Poerschke > Assignee: Christine Poerschke > Priority: Minor > Attachments: LUCENE-7788.patch > > > SOLR-10415 would be removing existing unparameterised log.trace messages use > and once that is in place then this ticket's one-line change would be for > 'ant precommit' to reject any future unparameterised log.trace message use. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org