[
https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974887#comment-15974887
]
Christine Poerschke commented on LUCENE-7788:
---------------------------------------------
bq. ... it only catches cases when the logger is called {{log}} ...
Looks like the {{validLoggerPattern}} at
https://github.com/apache/lucene-solr/blob/master/build.xml#L174 is flexible on
names but in practice {{log}} is the most popular choice:
{code}
git grep " = LoggerFactory.getLogger" | sed 's/.* \(.* =
\)LoggerFactory.*/\1/g' | sort | uniq -c | sort -nr
482 log =
57 LOG =
23 logger =
1 requestLog =
{code}
So one option might be to change the 57+23+1 loggers that are not called
{{log}} and to then standardise on {{log}} via the validLoggerPattern and to
then proceed with some sort of check for {{log.trace}} and in due course
perhaps also {{log.debug}}?
> fail precommit on unparameterised log.trace messages
> ----------------------------------------------------
>
> Key: LUCENE-7788
> URL: https://issues.apache.org/jira/browse/LUCENE-7788
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: LUCENE-7788.patch
>
>
> SOLR-10415 would be removing existing unparameterised log.trace messages use
> and once that is in place then this ticket's one-line change would be for
> 'ant precommit' to reject any future unparameterised log.trace message use.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
