[
https://issues.apache.org/jira/browse/SOLR-10675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008844#comment-16008844
]
Hoss Man commented on SOLR-10675:
---------------------------------
bq. IMHO, the ref guide versions should maybe also in the version.properties
file. ...
It is _already_ based on the {{version}} in {{versions.properties}} -- there's
no need for a new distinct version# in there. Specifying
{{-Dsolr-guide-version=X.Y}} on the command line when building a guide release
is _just_ like specifying {{-Dversion=X.Y.Z}} when releasing the code -- the
only reason for the new/diff prop name on the command line is simply to allow
us to still read the (existing) {{version}} value from {{versions.properties}}
on the current branch to correctly identify which major.minor version of *solr*
we're publishing the guide for.
bq. And by the way, the PDF file on jenkins does not have "-SNAPSHOT" in the
version number ...
the branch_6_6 and branch_6x jenkins guide jobs both (currently) include
{{-DRAFT}} in their artifact name as intended. the master jenkis guide job
does not -- but that's only because that job last ran *BEFORE* i committed
these changes.
The choice of "-DRAFT" vs "-SNAPSHOT" was deliberate to be consistent with the
way we refered to the cwiki content prior to this migration. If you think we
should cahnge that please file a new issue. (Personally i think that while
SNAPSHOT makes sense for "code builds", the term "DRAFT" will be easier for
folks to udnerstand in the context of documentation.
> differentiate DRAFT builds of the html/pdf ref-guides vs the official releases
> ------------------------------------------------------------------------------
>
> Key: SOLR-10675
> URL: https://issues.apache.org/jira/browse/SOLR-10675
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: documentation
> Reporter: Hoss Man
> Assignee: Hoss Man
> Fix For: 6.6, master (7.0)
>
> Attachments: draft-background.png, SOLR-10675.patch
>
>
> We should tweak the build system for the new ref guide so that it's obvious
> from the artifacts when they are unofficial "DRAFT" copies (default) vs
> official releases
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
