[
https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017765#comment-16017765
]
Jason Gerlowski commented on SOLR-10713:
----------------------------------------
You're right that some of the file formats I take issue against do tend to be
found in particular directories. ({{*.pid}} files, for example, are always
found in the same directory as a result of the current {{bin/solr}}
implementation.).
I considered taking a more conservative description of these paths in
{{.gitignore}}, but opted against it- {{.out}}, {{.err}}, and {{.pid}} files
are all output files of one type of another and shouldn't be committed whether
they're in a path we anticipated or not.
(Technically this is just convention- someone could store their source code or
config in a {{.out}} file, but I'd argue the convention is strong/universal
enough to go along with.)
If you (or others) feel I've overreached here though, I'm happy to update the
.gitignore with more conservative wildcarding. Consider the above an
explanation of my approach, and not necessarily a defense.
> git should ignore common output files (*.pid, *.out)
> ----------------------------------------------------
>
> Key: SOLR-10713
> URL: https://issues.apache.org/jira/browse/SOLR-10713
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Jason Gerlowski
> Priority: Trivial
> Attachments: SOLR-10713.patch, SOLR-10713.patch
>
>
> During the course of experimenting/testing Solr, it's common to accumulate a
> number of output files in the source checkout. Many of these are already
> ignored via the {{.gitignore}}. (For example, {{*.jar}} and {{*.log}} files
> are untracked currently)
> Some common output files aren't explicitly ignored by git though. I know
> this is true of {{*.pid}} and {{*.out}} files (such as those produced by
> running a standalone ZK).
> It'd be nice if we could update the {{.gitignore}} to explicitly ignore these
> filetypes by default.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
