[
https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035491#comment-16035491
]
Mike Drob commented on SOLR-10713:
----------------------------------
Let's get the easy parts committed and not worry about the hard parts for now
(i.e. collection directories) - we can always come back to them later if
somebody decides they're enough of a problem to solve rather than a
hypothetical problem to try and handle. What's the phrase... striving to
better, oft we mar what's well?
I'm not sure it makes a difference, but when moving entries from the top-level
to the solr specific ignore list, some retained the leading slash and some lost
it. I went looking at {{man gitignore}}, and discovered these two entries:
* A leading slash matches the beginning of the pathname. For example,
"/*.c" matches "cat-file.c" but not "mozilla-sha1/sha1.c".
* A leading "**" followed by a slash means match in all directories.
For example, "**/foo" matches file or directory "foo" anywhere, the
same as pattern "foo"
So let's drop leading **, and also get consistent about our use of leading
slash.
I have no preference on {{.patch}} files. Maybe leave them out so that they
still get shown by {{git status}} and the user can be reminded that they exist.
I think the risk of accidentally committing one is low and the remedy is simple
since conflicts and dependancies on {{SOLR-XXX.patch}} should be unlikely.
> git should ignore common output files (*.pid, *.out)
> ----------------------------------------------------
>
> Key: SOLR-10713
> URL: https://issues.apache.org/jira/browse/SOLR-10713
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Jason Gerlowski
> Assignee: Mike Drob
> Priority: Trivial
> Attachments: SOLR-10713.patch, SOLR-10713.patch, SOLR-10713.patch,
> SOLR-10713.patch
>
>
> During the course of experimenting/testing Solr, it's common to accumulate a
> number of output files in the source checkout. Many of these are already
> ignored via the {{.gitignore}}. (For example, {{*.jar}} and {{*.log}} files
> are untracked currently)
> Some common output files aren't explicitly ignored by git though. I know
> this is true of {{*.pid}} and {{*.out}} files (such as those produced by
> running a standalone ZK).
> It'd be nice if we could update the {{.gitignore}} to explicitly ignore these
> filetypes by default.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
