Yes definitely -- add descriptions, and make the smoke tester more clear. BTW I saw you commit javadocs to PeerSync and some other files in which you placed @lucene.experimental before the actual description instead of last. I've *never* seen that before... perhaps it's valid but it's very non-standard to say the least.
Thanks for being the RM. I'll try it one of these days. ~ David On Thu, May 25, 2017 at 8:23 AM Ishan Chattopadhyaya < [email protected]> wrote: > David, > Regarding SOLR-10004, those warnings are due to missing javadocs > descriptions. I've added javadocs for a few classes to see if the warnings > for those files disappear. If that is actually the root cause for this, we > have three options ahead of us: > > 1. Lets add descriptions to all affected classes before the next RC. > 2. Lets either suppress those warnings or mentally ignore them ourselves. > 3. Edit the warning message appropriately at the smoke tester to make the > cause clearly. > > I suggest we go with the next RC, and try option 3. > > Thoughts? > > Regards, > Ishan > > > On Thu, May 25, 2017 at 12:42 PM, Ishan Chattopadhyaya < > [email protected]> wrote: > >> > -1 on my own new example :-( >> >> Okay, lets re-spin. >> >> > I still get the javadocs warning I last reported but I'll accept that >> as the new(?) normal. >> >> I couldn't understand why it was happening or how to fix it. SOLR-10004. >> The package-info.java files are present, so I can't understand why these >> files are missing. Would really appreciate if someone knowledgeable can >> kindly look into this before the next RC. >> >> >> On Thu, May 25, 2017 at 11:02 AM, Alexandre Rafalovitch < >> [email protected]> wrote: >> >>> -1 on my own new example :-( >>> >>> DIH Atom example suddenly no longer works because StackOverflow has >>> JUST moved to https and our URL pulling implementation apparently does >>> not follow the redirect and fails silently. >>> >>> https://stackoverflow.blog/2017/05/22/stack-overflow-flipped-switch-https/ >>> >>> The change is 1 character in the >>> example/example-DIH/solr/atom/conf/atom-data-config.xml from "http" in >>> the url to "https". I've committed it to master, branch_6x and >>> branch_6_6 just now. >>> >>> Regards, >>> Alex. >>> P.s. The logs also complain about other libraries not loaded (for >>> different DIH cores), but I think that's a long standing issue and is >>> not a blocker. >>> ---- >>> http://www.solr-start.com/ - Resources for Solr users, new and >>> experienced >>> >>> >>> On 24 May 2017 at 23:50, David Smiley <[email protected]> wrote: >>> > +1 >>> > >>> > SUCCESS! [0:54:26.342469] >>> > >>> > I still get the javadocs warning I last reported but I'll accept that >>> as the >>> > new(?) normal. >>> > ~ David >>> > >>> > On Wed, May 24, 2017 at 2:58 PM Ishan Chattopadhyaya >>> > <[email protected]> wrote: >>> >> >>> >> Please vote for release candidate 2 for Lucene/Solr 6.6.0 >>> >> >>> >> The artifacts can be downloaded from: >>> >> >>> >> >>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-6.6.0-RC2-rev87107084c3a90f7ef253c00423b12cc1790f8c2f >>> >> >>> >> You can run the smoke tester directly with this command: >>> >> >>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \ >>> >> >>> >> >>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-6.6.0-RC2-rev87107084c3a90f7ef253c00423b12cc1790f8c2f >>> >> >>> >> Here's my +1 >>> >> SUCCESS! [0:58:58.949598] >>> >> >>> > -- >>> > Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker >>> > LinkedIn: http://linkedin.com/in/davidwsmiley | Book: >>> > http://www.solrenterprisesearchserver.com >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >> > -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com
