[
https://issues.apache.org/jira/browse/SOLR-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036927#comment-16036927
]
ASF subversion and git services commented on SOLR-10671:
--------------------------------------------------------
Commit 2271e73e763b17f971731f6f69d6ffe46c40b944 in lucene-solr's branch
refs/heads/master from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2271e73 ]
SOLR-10671: Add abstract doInit method to the SolrMetricReporter base class.
(Christine Poerschke, Anshum Gupta)
> tweak SolrMetricReporter implementations' init/validate/start logic
> -------------------------------------------------------------------
>
> Key: SOLR-10671
> URL: https://issues.apache.org/jira/browse/SOLR-10671
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-10671.patch, SOLR-10671.patch
>
>
> This ticket proposes to
> * add abstract doInit method to the SolrMetricReporter base class
> * turn Solr(Cluster|Shard)Reporter.validate into
> Solr(Cluster|Shard)Reporter.doInit
> * factor out Solr(Ganglia|Graphite|Slf4j)Reporter.doInit from
> Solr(Ganglia|Graphite|Slf4j)Reporter.validate
> Motivation and Intention:
> * Consistency w.r.t. what logic SolrMetricReport implementations should place
> in which method.
> * Even reporters that are not enabled to pass the validate() check.
> * The validate() method to have no (init-ialising) side effects.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
