[
https://issues.apache.org/jira/browse/SOLR-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038050#comment-16038050
]
Hoss Man commented on SOLR-10807:
---------------------------------
bq. ... other idea that occured to me is to go ahead and kludge in a quick ...
assumes docValues="true" unless explicitly told otherwise ... This might
produce more "false failures" in whitebox style tests, or in TestPointFields
where it's expecting errors when docValues aren't used ..
This idea was largely a bust so i didn't even bother committing it. It did in
fact produce more errors in whitebox tests (and or test that did a good job
sanity checking their schema expectations), but what i didn't really think
through is that most tests are defining {{docValues="foo"}} directly on the
field/dynamicField and not inheriting it from the fieldType ... so kludging
this into PointField.init() didn't really help in most cases (i guess maybe it
would have to be hacked into SchemaField, with an instanceof check on the
FieldType ?)
Of the new failures It did turn up, there were 2 interesting/non-obvious
failures (note: these won't reproduce on any committed version of the branch
... just posting here so i remember to look into these later)
{noformat}
### Grouped Facets has explicit assumptions about DocVals type?
[junit4] 2> 287824 INFO
(TEST-SimpleFacetsTest.testSimpleGroupedFacets-seed#[63854996088ED7B7]) [ ]
o.a.s.SolrTestCaseJ4 ###Ending testSimpleGroupedFacets
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=SimpleFacetsTest
-Dtests.method=testSimpleGroupedFacets -Dtests.seed=63854996088ED7B7
-Dtests.slow=true -Dtests.locale=it -Dtests.timezone=SST -Dtests.asserts=true
-Dtests.file.encoding=ISO-8859-1
[junit4] ERROR 0.01s J2 | SimpleFacetsTest.testSimpleGroupedFacets <<<
[junit4] > Throwable #1: java.lang.RuntimeException: Exception during
query
[junit4] > at
__randomizedtesting.SeedInfo.seed([63854996088ED7B7:D674368DBC1D40A8]:0)
[junit4] > at
org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:940)
[junit4] > at
org.apache.solr.request.SimpleFacetsTest.testSimpleGroupedFacets(SimpleFacetsTest.java:386)
[junit4] > at
org.apache.solr.request.SimpleFacetsTest.testSimpleGroupedFacets(SimpleFacetsTest.java:374)
[junit4] > at java.lang.Thread.run(Thread.java:748)
[junit4] > Caused by: org.apache.solr.common.SolrException: Exception
during facet.field: duration_i1
[junit4] > at
org.apache.solr.request.SimpleFacets.lambda$getFacetFieldCounts$0(SimpleFacets.java:812)
[junit4] > at
java.util.concurrent.FutureTask.run(FutureTask.java:266)
[junit4] > at
org.apache.solr.request.SimpleFacets$3.execute(SimpleFacets.java:745)
[junit4] > at
org.apache.solr.request.SimpleFacets.getFacetFieldCounts(SimpleFacets.java:821)
[junit4] > at
org.apache.solr.handler.component.FacetComponent.getFacetCounts(FacetComponent.java:329)
[junit4] > at
org.apache.solr.handler.component.FacetComponent.process(FacetComponent.java:273)
[junit4] > at
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:295)
[junit4] > at
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:178)
[junit4] > at
org.apache.solr.core.SolrCore.execute(SolrCore.java:2487)
[junit4] > at
org.apache.solr.util.TestHarness.query(TestHarness.java:337)
[junit4] > at
org.apache.solr.util.TestHarness.query(TestHarness.java:319)
[junit4] > at
org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:914)
[junit4] > ... 41 more
[junit4] > Caused by: java.lang.IllegalStateException: unexpected
docvalues type NUMERIC for field 'duration_i1' (expected=SORTED). Re-index with
correct docvalues type.
### (distributed?) HLL hashing bug?
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=TestDistributedStatsComponentCardinality -Dtests.method=test
-Dtests.seed=63854996088ED7B7 -Dtests.slow=true -Dtests.locale=de-GR
-Dtests.timezone=Etc/UCT -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
[junit4] FAILURE 13.3s J2 | TestDistributedStatsComponentCardinality.test <<<
[junit4] > Throwable #1: java.lang.AssertionError: int_i: hashed vs
prehashed, real=7260,
p=q=id:[1186+TO+8445]&rows=0&stats=true&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8}int_i&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8+hllPreHashed%3Dtrue}int_i_prehashed_l&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8}long_l&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8+hllPreHashed%3Dtrue}long_l_prehashed_l&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8}string_s&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8+hllPreHashed%3Dtrue}string_s_prehashed_l
expected:<6632> but was:<7929>
[junit4] > at
__randomizedtesting.SeedInfo.seed([63854996088ED7B7:EBD1764CA672BA4F]:0)
[junit4] > at
org.apache.solr.handler.component.TestDistributedStatsComponentCardinality.test(TestDistributedStatsComponentCardinality.java:149)
{noformat}
> Randomize PointFields in all tests unless explicit reason not to
> -----------------------------------------------------------------
>
> Key: SOLR-10807
> URL: https://issues.apache.org/jira/browse/SOLR-10807
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Hoss Man
> Priority: Blocker
> Fix For: master (7.0)
>
> Attachments:
> core.test.log.fde06f34b7f9d0916a134b3efaa8780892ff8e39.txt, core.test.log.txt
>
>
> We need to seriously beef up our testing of PointFields to figure out what
> Solr features don't currently work with PointFields.
> The existing Trie/Point randomization logic in SolrTestCaseJ4 is a good start
> -- but only a handful of schema files leverage it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
