[ 
https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042630#comment-16042630
 ] 

Trey Grainger commented on SOLR-10494:
--------------------------------------

Started working on this two weeks ago and then got busy. The actual changes 
were super quick, but after I made them it was taking over 2 hours to run the 
unit tests with lots of failures and several test suites timing out.

Just got back to this today and have pretty much everything diagnosed and am 
working on fixes. In short, SolrTestCaseJ4 has XPath checking hard-coded in its 
design, so I need to now pass in wt=xml explicitly there, and there are a 
handful of test suites (i.e. replication/backup/restore and hdfs) that are 
explicitly checking XML strings and looping forever until they get those 
strings back (hence timing out).

I'm making changes to explicitly request XML right now for those tests where 
they are expecting it and will get a patch posted hopefully today.

> Switch Solr's Default Response Type from XML to JSON
> ----------------------------------------------------
>
>                 Key: SOLR-10494
>                 URL: https://issues.apache.org/jira/browse/SOLR-10494
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: master (7.0)
>            Reporter: Trey Grainger
>            Priority: Minor
>             Fix For: master (7.0)
>
>
> Solr's default response format is still XML, despite the fact that Solr has 
> supported the JSON response format for over a decade, developer mindshare has 
> clearly shifted toward JSON over the years, and most modern/competing systems 
> also use JSON format now by default.
> In fact, Solr's admin UI even explicitly adds wt=json to the request (by 
> default in the UI) to override the default of wt=xml, so Solr's Admin UI 
> effectively has a different default than the API.
> We have now introduced things like the JSON faceting API, and the new more 
> modern /V2 apis assume JSON for the areas of Solr they cover, so clearly 
> we're moving in the direction of JSON anyway.
> I'd like propose that we switch the default response writer to JSON (wt=json) 
> instead of XML for Solr 7.0, as this seems to me like the right direction and 
> a good time to make this change with the next major version.
> Based upon feedback from the Lucene Dev's mailing list, we want to:
> 1) Change the default response writer type to "wt=json" and also change to 
> "indent=on" by default
> 2) Make no changes on the update handler side; it already works as desired 
> (it returns the response in the same content-type as the request unless the 
> "wt" is passed in explicitly).
> 3) Keep the /query request handler around since people have already used it 
> for years to do JSON queries
> 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks 
> on how to change (back) the response format.
> The default format change, plus the addition of "indent=on" are back compat 
> changes, so we need to make sure we doc those clearly in the CHANGES.txt. 
> There will also need to be significant adjustments to the Solr Ref Guide, 
> Tutorial, etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to