[ 
https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042701#comment-16042701
 ] 

Trey Grainger commented on SOLR-10494:
--------------------------------------

Question: I'm making indent=on the default. Any objections if I make indent=on 
the default for all TextResponseWriters, or do I need to limit the change to 
only the "wt=json" (now default writer) case.

The writers impacted from what I can tell are:
GEOJSONWriter
JSONWriter
XMLWriter
SchemaXMLWriter
PHPWriter
PythonWriter
RubyWriter

It's a little complicated because most of these (geojson, php, python, ruby) 
actually inherit from the JSONWriter, so if I need to leave indent=off on those 
then I have to go in and set it explicitly on them since their base class will 
now have indent on by default.

Unless anyone objects, I'm just going to set indent=on by default on all of 
these. Please let me know if anyone disagrees.

> Switch Solr's Default Response Type from XML to JSON
> ----------------------------------------------------
>
>                 Key: SOLR-10494
>                 URL: https://issues.apache.org/jira/browse/SOLR-10494
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: master (7.0)
>            Reporter: Trey Grainger
>            Priority: Minor
>             Fix For: master (7.0)
>
>
> Solr's default response format is still XML, despite the fact that Solr has 
> supported the JSON response format for over a decade, developer mindshare has 
> clearly shifted toward JSON over the years, and most modern/competing systems 
> also use JSON format now by default.
> In fact, Solr's admin UI even explicitly adds wt=json to the request (by 
> default in the UI) to override the default of wt=xml, so Solr's Admin UI 
> effectively has a different default than the API.
> We have now introduced things like the JSON faceting API, and the new more 
> modern /V2 apis assume JSON for the areas of Solr they cover, so clearly 
> we're moving in the direction of JSON anyway.
> I'd like propose that we switch the default response writer to JSON (wt=json) 
> instead of XML for Solr 7.0, as this seems to me like the right direction and 
> a good time to make this change with the next major version.
> Based upon feedback from the Lucene Dev's mailing list, we want to:
> 1) Change the default response writer type to "wt=json" and also change to 
> "indent=on" by default
> 2) Make no changes on the update handler side; it already works as desired 
> (it returns the response in the same content-type as the request unless the 
> "wt" is passed in explicitly).
> 3) Keep the /query request handler around since people have already used it 
> for years to do JSON queries
> 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks 
> on how to change (back) the response format.
> The default format change, plus the addition of "indent=on" are back compat 
> changes, so we need to make sure we doc those clearly in the CHANGES.txt. 
> There will also need to be significant adjustments to the Solr Ref Guide, 
> Tutorial, etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to