[ https://issues.apache.org/jira/browse/SOLR-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041749#comment-13041749 ]
Robert Muir commented on SOLR-2193: ----------------------------------- {quote} However I think the patch is creating new abstract classes, that would then go away? {quote} Just one interface right, IndexWriterProvider? Mark seems to describe the reasoning behind this pretty well: {quote} 7. Address the current issues we face because multiple original/'reloaded' cores can have a different IndexWriter on the same index. I've made an attempt at this with the IndexWriterProvider and some simple ref counting that could use a once over. This changes how you should reload a Solrcore - rather than just opening a new one and closing the old one, you want to call a method on the SolrCore itself and get the new SolrCore. {quote} and in the original goals {quote} solving our rather nasty reload a core, briefly different writers on the same index problem (usually avoided because the overlap is brief and the IndexWriter created lazily). {quote} I'm at best a Solr dummy, but it seems to me to be a good tradeoff. We could toss @lucene.internal or @lucene.experimental on this so its clear that things are still in flux? > Re-architect Update Handler > --------------------------- > > Key: SOLR-2193 > URL: https://issues.apache.org/jira/browse/SOLR-2193 > Project: Solr > Issue Type: Improvement > Reporter: Mark Miller > Fix For: 4.0 > > Attachments: SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch, > SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch > > > The update handler needs an overhaul. > A few goals I think we might want to look at: > 1. Cleanup - drop DirectUpdateHandler(2) line - move to something like > UpdateHandler, DefaultUpdateHandler > 2. Expose the SolrIndexWriter in the api or add the proper abstractions to > get done what we now do with special casing: > if (directupdatehandler2) > success > else > failish > 3. Stop closing the IndexWriter and start using commit (still lazy IW init > though). > 4. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level. > 5. Keep NRT support in mind. > 6. Keep microsharding in mind (maintain logical index as multiple physical > indexes) > 7. Address the current issues we face because multiple original/'reloaded' > cores can have a different IndexWriter on the same index. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org