[ https://issues.apache.org/jira/browse/SOLR-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041767#comment-13041767 ]
Jason Rutherglen commented on SOLR-2193: ---------------------------------------- {quote}solving our rather nasty reload a core, briefly different writers on the same index problem (usually avoided because the overlap is brief and the IndexWriter created lazily).{quote} Robert I fully agree, however then the title of the Jira is incorrect. Also the whole ref counted thing in Solr: {code} RefCounted<SolrIndexSearcher> holder = core.getNewestSearcher(false); SolrIndexSearcher s = holder.get(); holder.decref(); // since there could be two commits in a row, don't test for a specific new searcher // just test that the old one has been replaced. {code} Should not be needed anymore. We're also adding ref counting on IWs now as well? All of this is unnecessary. If we're modularizing, this isn't right path to go one. > Re-architect Update Handler > --------------------------- > > Key: SOLR-2193 > URL: https://issues.apache.org/jira/browse/SOLR-2193 > Project: Solr > Issue Type: Improvement > Reporter: Mark Miller > Fix For: 4.0 > > Attachments: SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch, > SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch > > > The update handler needs an overhaul. > A few goals I think we might want to look at: > 1. Cleanup - drop DirectUpdateHandler(2) line - move to something like > UpdateHandler, DefaultUpdateHandler > 2. Expose the SolrIndexWriter in the api or add the proper abstractions to > get done what we now do with special casing: > if (directupdatehandler2) > success > else > failish > 3. Stop closing the IndexWriter and start using commit (still lazy IW init > though). > 4. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level. > 5. Keep NRT support in mind. > 6. Keep microsharding in mind (maintain logical index as multiple physical > indexes) > 7. Address the current issues we face because multiple original/'reloaded' > cores can have a different IndexWriter on the same index. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org