[
https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047738#comment-16047738
]
Shalin Shekhar Mangar commented on SOLR-8392:
---------------------------------------------
I'm seeing test failures (specifically TestSolrConfigHandlerCloud) related to
this change with the following in the logs:
{code}
25770 ERROR (qtp45094468-154) [n:127.0.0.1:39181_ c:collection1 s:shard1
r:core_node4 x:collection1] o.a.s.s.HttpSolrCall
null:java.lang.ClassCastException: [Ljava.lang.String; cannot be cast to
java.lang.String
at
org.apache.solr.common.params.MapSolrParams.getParams(MapSolrParams.java:39)
at
org.apache.solr.common.params.MultiMapSolrParams.asMultiMap(MultiMapSolrParams.java:103)
at
org.apache.solr.common.params.MultiMapSolrParams.asMultiMap(MultiMapSolrParams.java:81)
at
org.apache.solr.request.json.RequestUtil.processParams(RequestUtil.java:119)
at
org.apache.solr.util.SolrPluginUtils.setDefaults(SolrPluginUtils.java:177)
at
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:175)
at org.apache.solr.core.SolrCore.execute(SolrCore.java:2487)
at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:722)
at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:528)
at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:374)
at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:318)
{code}
> SolrParam.get(String) returns String and shouldn't be used in other
> instanceof checks
> -------------------------------------------------------------------------------------
>
> Key: SOLR-8392
> URL: https://issues.apache.org/jira/browse/SOLR-8392
> Project: Solr
> Issue Type: Bug
> Reporter: Mike Drob
> Assignee: Mike Drob
> Fix For: master (7.0)
>
> Attachments: SOLR-8392.patch, SOLR-8392.patch
>
>
> There's a couple of places where we declare the return type of
> solrParams.get() as an Object and then do instanceof checks for other types.
> Since we know it will be a String, we can simplify this logic in several
> places.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
