[
https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048598#comment-16048598
]
ASF subversion and git services commented on SOLR-8392:
-------------------------------------------------------
Commit d1db5f7af9edb2125583c6c63fa322380ee57cf7 in lucene-solr's branch
refs/heads/jira/SOLR-10834 from [~mdrob]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d1db5f7 ]
Revert "SOLR-8392: Remove instanceof checks on return value of SolrParam::get"
This reverts commit 94220a01e14f53e0632bfbc1678661ad9c67320a.
> SolrParam.get(String) returns String and shouldn't be used in other
> instanceof checks
> -------------------------------------------------------------------------------------
>
> Key: SOLR-8392
> URL: https://issues.apache.org/jira/browse/SOLR-8392
> Project: Solr
> Issue Type: Bug
> Reporter: Mike Drob
> Assignee: Mike Drob
> Fix For: master (7.0)
>
> Attachments: SOLR-8392.patch, SOLR-8392.patch
>
>
> There's a couple of places where we declare the return type of
> solrParams.get() as an Object and then do instanceof checks for other types.
> Since we know it will be a String, we can simplify this logic in several
> places.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
