[ 
https://issues.apache.org/jira/browse/LUCENE-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael McCandless updated LUCENE-7868:
---------------------------------------
    Attachment: LUCENE-7868.patch

Another iteration, I think it's ready!

All nocommits are gone, all tests and "ant precommit" passes.  I'll beast all 
tests some more before pushing.

I improved how we compress the frozen packet of DV updates for better RAM 
efficiency: each frozen packet is ~8.3% of the original size of the un-frozen 
packet in my benchmark.

I also tested DV updates performance, updating the price field in my internal 
corpus.  With no refresh (just writing DV updates when RAM buffer is full) 
trunk updates at 8.0 K docs/sec, and the patch 58.0 K docs/sec (7.25X faster).  
With refresh every 60 seconds, trunk gets 7.4 K docs/sec and the patch gets 
63.7 K docs/sec (8.6X faster).  This is with 12 threads, 128 MB IW buffer.




> Use multiple threads to apply deletes and DV updates
> ----------------------------------------------------
>
>                 Key: LUCENE-7868
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7868
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: master (7.0)
>
>         Attachments: cpu-after.png, cpu-before.png, LUCENE-7868.patch, 
> LUCENE-7868.patch, LUCENE-7868.patch, LUCENE-7868.patch
>
>
> Today, when users delete documents or apply doc values updates, IndexWriter 
> buffers them up into frozen packets and then eventually uses a single thread 
> (BufferedUpdatesStream.applyDeletesAndUpdates) to resolve delete/update terms 
> to docids.  This thread also holds IW's monitor lock, so it also blocks 
> refresh, merges starting/finishing, commits, etc.
> We have heavily optimized this part of Lucene over time, e.g. LUCENE-6161, 
> LUCENE-2897, LUCENE-2680, LUCENE-3342, but still, it's a single thread so it 
> can't use multiple CPU cores commonly available now.
> This doesn't affect append-only usage, but for update-heavy users (me!) this 
> can be a big bottleneck, and causes long stop-the-world hangs during indexing.
> I have an initial exploratory patch to make these lookups concurrent, without 
> holding IW's lock, so that when a new packet of deletes is pushed, which 
> happens when we flush a new segment, we immediately use that same indexing 
> thread to and resolve the deletions.
> This is analogous to when we made segment flushing concurrent (LUCENE-3023), 
> just for deletes and DV updates as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to