[
https://issues.apache.org/jira/browse/LUCENE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-7737:
----------------------------------
Attachment: LUCENE-7737.patch
Thanks for the review David! Here's an updated patch.
bq. I see DoubleValueSource.explain was changed from being abstract to having a
default implementation
After I implemented the exact same vanilla explain() method four times, I
decided to pull it up :) There hasn't been a release with an abstract
explain(), so I didn't think it needed a new issue? Maybe an amendment to the
CHANGES entry is in order though.
bq. in LatLonPointSpatialField did you purposefully remove
{{@SuppressWarnings("unchecked")}} for the cast?
No, that was an error. It's back.
bq. perhaps move GeoDistValueSourceParser.WrappedDoubleValueSource to
ValueSource.toDoubleValueSource (inverse of .asDoubleValueSource) ?
Done
bq. SerializedDVStrategy.ShapeDocValueSource: You can now simply remove the
BytesRefBuilder here
Done
bq. Maybe define ShapeValues as inner class of ShapeValueSource?
I'm less keen on this. The analogy is with DoubleValuesSource/DoubleValues and
LongValuesSource/LongValues, which are all separate classes.
bq. Why the changes to geo3d test stuff?
No idea where that came from, have reverted it
bq. Why the change to DistanceStrategyTest?
ValueSource needs to work around deleted docs. DoubleValuesSource doesn't,
it's all handled by whatever drives the search, so there's no point in testing
it here.
bq. ShapePredicate's javadocs are no longer correct as it's no longer a
ValueSource
Renamed, and improved the javadocs.
I'm now getting a (very occasional) failure in Geo3dRptTest, do you think you
could have a look?
{code}
ant test -Dtestcase=Geo3dRptTest -Dtests.method=testOperations
-Dtests.seed=CCFBCE7086968E3 -Dtests.locale=ar-BH
-Dtests.timezone=Africa/Timbuktu -Dtests.asserts=true
-Dtests.file.encoding=ISO-8859-1
{code}
> Remove spatial-extras dependency on queries
> -------------------------------------------
>
> Key: LUCENE-7737
> URL: https://issues.apache.org/jira/browse/LUCENE-7737
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial-extras
> Reporter: Alan Woodward
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: LUCENE-7737.patch, LUCENE-7737.patch, LUCENE-7737.patch
>
>
> The spatial-extras module uses ValueSources for a number of different
> purposes, requiring a dependency on the queries module. I'd like to try
> using core-only interfaces here instead, allowing us to remove the dependency
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
