[
https://issues.apache.org/jira/browse/LUCENE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-7737:
----------------------------------
Attachment: LUCENE-7737.patch
bq. Your move of code to fromDoubleValuesSource didn't compile
Fixorated
bq. More outdated javadocs
Ditto
bq. Regarding the test (Geo3d) failure
This too, thanks for digging
bq. During my debugging, I kept looking at IntersectsRPTVerifyQuery.createWeight
Yeah, this is confusing. I've made the change you suggested, but the whole
thing is still a bit odd. I guess it's a form of two-phase iteration that you
wrote before we had the core TwoPhaseIterator API? There are several TODOs in
there that are probably worth revisiting, but maybe in a separate issue.
> Remove spatial-extras dependency on queries
> -------------------------------------------
>
> Key: LUCENE-7737
> URL: https://issues.apache.org/jira/browse/LUCENE-7737
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial-extras
> Reporter: Alan Woodward
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: LUCENE-7737.patch, LUCENE-7737.patch, LUCENE-7737.patch,
> LUCENE-7737.patch
>
>
> The spatial-extras module uses ValueSources for a number of different
> purposes, requiring a dependency on the queries module. I'd like to try
> using core-only interfaces here instead, allowing us to remove the dependency
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
