[
https://issues.apache.org/jira/browse/SOLR-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071788#comment-16071788
]
Jan Høydahl commented on SOLR-6671:
-----------------------------------
Thanks Uwe, I committed the fix quickly without checking precommit.
Your edits are fine, I was not aware of {{Constants.WINDOWS}}. I thought of
making the assert more generic and move it to some test Util class, but this
was the bare minimum of what was needed. Perhaps it would be more readable to
have separate {{assertDataHome}} calls for Win and Linux:
{code}
if (Constants.WINDOWS) {
assertDataHome("C:\\solrdata\\inst_dir\\data", "inst_dir", rdf, cc);
} else {
assertDataHome("/solrdata/inst_dir/data", "inst_dir", rdf, cc);
}
{code}
> Introduce a solr.data.home as root dir for all data
> ---------------------------------------------------
>
> Key: SOLR-6671
> URL: https://issues.apache.org/jira/browse/SOLR-6671
> Project: Solr
> Issue Type: New Feature
> Components: SolrCloud
> Affects Versions: 4.10.1
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Fix For: master (7.0)
>
> Attachments: SOLR-6671.patch, SOLR-6671.patch, SOLR-6671.patch,
> SOLR-6671.patch, SOLR-6671.patch, SOLR-6671.patch, SOLR-6671.patch,
> SOLR-6671.patch
>
>
> Many users prefer to deploy code, config and data on separate disk locations,
> so the default of placing the indexes under
> {{$\{solr.solr.home\}/$\{solr.core.name\}/data}} is not always wanted.
> In a multi-core/collection system, there is not much help in the
> {{solr.data.dir}} option, as it would set the {{dataDir}} to the same folder
> for all collections. One workaround, if you don't want to hardcode paths in
> your {{solrconfig.xml}}, is to specify the {{dataDir}} property in each
> {{solr.properties}} file.
> A more elegant solution would be to introduce a new Java-option
> {{solr.data.home}} which would be to data the same as {{solr.solr.home}} is
> for config. If set, all collections would default their {{dataDir}} as
> {{$\{solr.data.home\)/$\{solr.core.name\}/data}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
