[
https://issues.apache.org/jira/browse/SOLR-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071803#comment-16071803
]
Uwe Schindler commented on SOLR-6671:
-------------------------------------
Hi Jan,
I think the fixes as committed are fine.
In addition I changed your regex to allow drive names other than "C:", because
on Windows the drive is inherited. If you have your checkout on D: or X:, it
would return another path, so the code above won't work!
IMHO: The correct fix would be to just resolve the path name completely (get
absolute name) and then compare the {{Path}} objects. String comparisons of
folder names are always likely to break. With {{Path}} objects everything is
right: slashes and drives are there. I did not fix that because I just wanted
to correct it and not change semantics of your patch. I added the TODO, to
think about how to do it better!
> Introduce a solr.data.home as root dir for all data
> ---------------------------------------------------
>
> Key: SOLR-6671
> URL: https://issues.apache.org/jira/browse/SOLR-6671
> Project: Solr
> Issue Type: New Feature
> Components: SolrCloud
> Affects Versions: 4.10.1
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Fix For: master (7.0)
>
> Attachments: SOLR-6671.patch, SOLR-6671.patch, SOLR-6671.patch,
> SOLR-6671.patch, SOLR-6671.patch, SOLR-6671.patch, SOLR-6671.patch,
> SOLR-6671.patch
>
>
> Many users prefer to deploy code, config and data on separate disk locations,
> so the default of placing the indexes under
> {{$\{solr.solr.home\}/$\{solr.core.name\}/data}} is not always wanted.
> In a multi-core/collection system, there is not much help in the
> {{solr.data.dir}} option, as it would set the {{dataDir}} to the same folder
> for all collections. One workaround, if you don't want to hardcode paths in
> your {{solrconfig.xml}}, is to specify the {{dataDir}} property in each
> {{solr.properties}} file.
> A more elegant solution would be to introduce a new Java-option
> {{solr.data.home}} which would be to data the same as {{solr.solr.home}} is
> for config. If set, all collections would default their {{dataDir}} as
> {{$\{solr.data.home\)/$\{solr.core.name\}/data}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
