[ 
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156438#comment-16156438
 ] 

David Smiley commented on LUCENE-7951:
--------------------------------------

[~ivera] I'd prefer a GitHub Pull Request if we make further changes.  You need 
need to reference this LUCENE-7951 in the PR title.  But if that's inconvenient 
for you then we can continue with patch files nonetheless.  Locally I've 
modified a couple things a bit; if we go the PR route it's easier for me to 
retain them as we go.

Why the distinction between Geo3dAreaShape & Geo3dShape?  I doubt we need both 
but maybe I'm missing something.

RandomGeoShapeGenerator
* I love it.  Did you extract this from Geo3dRptTest?  Maybe this ought to live 
in spatial-3d test area and simply referenced here?  What do you think 
[~kwri...@metacarta.com]?
* I think the "Geo" should be "Geo3d" in its name for clarity.



> New wrapper classes for Geo3d
> -----------------------------
>
>                 Key: LUCENE-7951
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7951
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial-extras
>            Reporter: Ignacio Vera
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: LUCENE-7951.patch, LUCENE-7951.patch
>
>
> Hi,
> After the latest developments in the Geo3d library, in particular:
> [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships 
> between GeoShapes
> [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of 
> GeoShapes.
> I propose a new set of wrapper classes which can be for example linked to 
> Solr as they implement their own SpatialContextFactory. It provides the 
> capability of indexing shapes with 
>  spherical geometry.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to