[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158617#comment-16158617
]
David Smiley commented on LUCENE-7951:
--------------------------------------
bq. We must always construct the calculator if initCalculator() is called as
the planet model can be different.
Oh I see. Instead I suggest letting the planet model and calculator fields be
null initially. Overriding factory.newSpatialContext will allow us to do these
checks. This way, init(map) is still optional -- consistent with the other
SpatialContextFactory impls. There is a similar situation for "worldBounds".
In that case, the default SpatialContext impl knows checks and has defaulting
logic Since we don't have a custom SpatialContext impl for Geo3D, we could
just as easily override factory.newSpatialContext.
The PR looks good; I'll make further comments there. Thanks for doing a PR.
> New wrapper classes for Geo3d
> -----------------------------
>
> Key: LUCENE-7951
> URL: https://issues.apache.org/jira/browse/LUCENE-7951
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial-extras
> Reporter: Ignacio Vera
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE_7951_build.patch, LUCENE_7951_build.patch,
> LUCENE-7951.patch, LUCENE-7951.patch
>
>
> Hi,
> After the latest developments in the Geo3d library, in particular:
> [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships
> between GeoShapes
> [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of
> GeoShapes.
> I propose a new set of wrapper classes which can be for example linked to
> Solr as they implement their own SpatialContextFactory. It provides the
> capability of indexing shapes with
> spherical geometry.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
