[
https://issues.apache.org/jira/browse/SOLR-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176733#comment-16176733
]
Hoss Man commented on SOLR-11372:
---------------------------------
[[email protected]]: I'm sorry i didn't get a chance to review your patch
sooner, but i'm -1 for the way you went about this ... you've introduced some
scary bobby traps for anyone who might work on this test in the future...
* You've changed the semantic meaning of "FACET_LIMIT" so that it no longer is
the "facet limit" (or is even an upper bound on the limit because of a *2 you
introduced??) w/o renaming the variable or adding any sort of comment to
clarify/reduce confusion in the future.
** even knowing this test very well, I can't make heads or tails of what your
_intended_ purpose of FACET_LIMIT is after your changes -- my best guess is
that it should be completley removed and usages should be replaced with
UNIQUE_FIELD_VALS?
* you've introduced hte new randomized refine/limit/overrequest logic directly
into the TermFacet.toJSONFacetParamValue() method -- instead of into the
TermFacet constructor along with all othe randomized state. This means that
for a given TermFacet object (or for 2 otherwise identical objects), two calls
to toJSONFacetParamValue() will now produce completely different results.
** If nothing else, this means that things like "testBespoke()" no longer
produce consistent reproducible facets -- whch defeats the entire point, and if
any bugs get introduced in refinement in the future, will make them that much
harder to track down.
> enable refinement testing in TestCloudJSONFacetJoinDomain
> ---------------------------------------------------------
>
> Key: SOLR-11372
> URL: https://issues.apache.org/jira/browse/SOLR-11372
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 7.1
>
> Attachments: SOLR-11372.patch
>
>
> This test has great random tests that ensure that the count returned for a
> bucket matches the number of documents returned from an equivalent filter.
> We should enable randomly testing smaller limits in conjunction with
> refinement to ensure we still get accurate counts for buckets that are
> returned.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
