[ 
https://issues.apache.org/jira/browse/SOLR-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176808#comment-16176808
 ] 

Yonik Seeley commented on SOLR-11372:
-------------------------------------

Yep, I clearly didn't make time to understand the larger test architecture - 
adding limit/refine/overrequest params to TermFacet makes much more sense (I 
just searched for the string "limit:" and went from there).  It may be a few 
weeks before I'm able to refactor things (I've been pulled into something else 
high priority), but feel free to refactor yourself or revert in the meantime.


> enable refinement testing in TestCloudJSONFacetJoinDomain
> ---------------------------------------------------------
>
>                 Key: SOLR-11372
>                 URL: https://issues.apache.org/jira/browse/SOLR-11372
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>             Fix For: 7.1
>
>         Attachments: SOLR-11372.patch
>
>
> This test has great random tests that ensure that the count returned for a 
> bucket matches the number of documents returned from an equivalent filter.  
> We should enable randomly testing smaller limits in conjunction with 
> refinement to ensure we still get accurate counts for buckets that are 
> returned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to