[ 
https://issues.apache.org/jira/browse/SOLR-11443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201095#comment-16201095
 ] 

Scott Blum commented on SOLR-11443:
-----------------------------------

Can you talk me through:

{code}
    if (knownChildren.containsAll(paths)) {
      knownChildren.removeAll(paths);
      stats.setQueueLength(knownChildren.size());
    } else {
      knownChildren.clear();
      isDirty = true;
    }
{code}

Seems like you could just always set this dirty; but if you're trying to 
in-memory surgery as an optimization, I don't understand the need for the 
containsAll check.

> Remove the usage of workqueue for Overseer
> ------------------------------------------
>
>                 Key: SOLR-11443
>                 URL: https://issues.apache.org/jira/browse/SOLR-11443
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Cao Manh Dat
>            Assignee: Cao Manh Dat
>         Attachments: SOLR-11443.patch, SOLR-11443.patch
>
>
> If we can remove the usage of workqueue, We can save a lot of IO blocking in 
> Overseer, hence boost performance a lot.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to