[
https://issues.apache.org/jira/browse/SOLR-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209323#comment-16209323
]
David Smiley commented on SOLR-11507:
-------------------------------------
+1 wonderful.
Also, from my "Find All Usages" examinations for the l getCloudSolrClient(...)
methods, it appears no test wants to explicitly set shardLeadersOnly to any
particular value. I think those test utility methods could be simplified to
not have this parameter.
FWIW I don't like the "get" terminology, I would have gone with "make" or "new"
or "create", and possibly one that actually returned the builder so the caller
has the option of setting setters to then call build() which is simple enough
and more explicit. This would be fewer utility methods that are of dubious need
if the usages are very few. Perhaps this stretches the scope of the issue a
little; I'd be happy to help if you don't want to [~cpoerschke]. What do you
think of this idea [~anshumg]? You committed this in SOLR-8097.
What I'm thinking:
{code:java}
public static CloudSolrClientBuilder newCloudSolrClient(String zkHost) {
return (CloudSolrClientBuilder) new
CloudSolrClientBuilder().withZkHost(zkHost);
}
{code}
> simplify and extend SolrTestCaseJ4.CloudSolrClientBuilder randomisation
> -----------------------------------------------------------------------
>
> Key: SOLR-11507
> URL: https://issues.apache.org/jira/browse/SOLR-11507
> Project: Solr
> Issue Type: Test
> Reporter: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-11507.patch
>
>
> [~dsmiley] wrote in SOLR-9090:
> bq. [~cpoerschke] I'm looking at {{SolrTestCaseJ4.CloudSolrClientBuilder}}.
> Instead of the somewhat complicated tracking using configuredDUTflag,
> couldn't you simply remove all that stuff and just modify the builder's
> constructor to randomize the settings?
> bq. Furthermore, shouldn't {{shardLeadersOnly}} be randomized as well?
> This ticket is to follow-up on that suggestion since SOLR-9090 is already
> closed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
