[
https://issues.apache.org/jira/browse/SOLR-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234969#comment-16234969
]
Jason Gerlowski commented on SOLR-11507:
----------------------------------------
+1 on the attached patch.
Note that with the setter-move, this is very similar SOLR-10469. (Not saying
that as a positive or negative, just as bookkeeping).
Most of the other setters have "move to setter" issues filed. I implemented
some of these, but stopped when there didn't seem to be much interest in
unifying the SolrClient setters. (I'd be happy to follow up on those related
issues though if that's a change you agree with, but I'm also happy to let it
go).
> simplify and extend SolrTestCaseJ4.CloudSolrClientBuilder randomisation
> -----------------------------------------------------------------------
>
> Key: SOLR-11507
> URL: https://issues.apache.org/jira/browse/SOLR-11507
> Project: Solr
> Issue Type: Test
> Reporter: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-11507.patch, SOLR-11507.patch
>
>
> [~dsmiley] wrote in SOLR-9090:
> bq. [~cpoerschke] I'm looking at {{SolrTestCaseJ4.CloudSolrClientBuilder}}.
> Instead of the somewhat complicated tracking using configuredDUTflag,
> couldn't you simply remove all that stuff and just modify the builder's
> constructor to randomize the settings?
> bq. Furthermore, shouldn't {{shardLeadersOnly}} be randomized as well?
> This ticket is to follow-up on that suggestion since SOLR-9090 is already
> closed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
