[ 
https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226945#comment-16226945
 ] 

Adrien Grand commented on LUCENE-8007:
--------------------------------------

bq. the codec (e.g. BlockTree) could just return docFreq and sumDocFreq instead

Good point. Given that PostingsEnum#freq returns 1 with DOCS_ONLY, that would 
be consistent.

bq. Also the patch corrects calculations for SImilarityBase but not BM25. We 
should either fix BM25 here too (essentially fold in LUCENE-8025) or just 
revert the change to SimilarityBase to avoid confusion? 

I did these changes since you suggested them in your previous comment. I will 
revert.

> Require that codecs always store totalTermFreq, sumDocFreq and 
> sumTotalTermFreq
> -------------------------------------------------------------------------------
>
>                 Key: LUCENE-8007
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8007
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>             Fix For: master (8.0)
>
>         Attachments: LUCENE-8007.patch, LUCENE-8007.patch, LUCENE-8007.patch
>
>
> Javadocs allow codecs to not store some index statistics. Given discussion 
> that occurred on LUCENE-4100, this was mostly implemented this way to support 
> pre-flex codecs. We should now require that all codecs store these statistics.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to