[ 
https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226966#comment-16226966
 ] 

Robert Muir commented on LUCENE-8007:
-------------------------------------

I think i caused confusion with my comments, sorry. I wanted to test the 
substitution (totalTermFreq=docFreq, sumTotalTermFreq=sumDocFreq) separately to 
ensure it worked well. Thats why i broke out LUCENE-8025, but I think its clear 
from measurements it is what we should do.

But really IMO BlockTree should do the substitution and we should remove 
fallback logic, since -1 becomes impossible. It will mean there is no longer 
-1s in sim stat apis at all. 

> Require that codecs always store totalTermFreq, sumDocFreq and 
> sumTotalTermFreq
> -------------------------------------------------------------------------------
>
>                 Key: LUCENE-8007
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8007
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>             Fix For: master (8.0)
>
>         Attachments: LUCENE-8007.patch, LUCENE-8007.patch, LUCENE-8007.patch
>
>
> Javadocs allow codecs to not store some index statistics. Given discussion 
> that occurred on LUCENE-4100, this was mostly implemented this way to support 
> pre-flex codecs. We should now require that all codecs store these statistics.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to