[ 
https://issues.apache.org/jira/browse/LUCENE-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264570#comment-16264570
 ] 

Ignacio Vera commented on LUCENE-8063:
--------------------------------------

I have a closer look and it seems I am allowed to build shapes where some 
points of the holes are actually outside of the shape. That is the reason it 
works when I add the bounds of the holes. (The tool I am using to vizualize the 
shape does not complain either so I am very puzzle, it seems valid as well)

If you get the bounds of a shape and you build the bounding box, then the shape 
should be WITHIN the bounding box. In spatial3d, it can be OVERLAPS because if 
the shape is touching one of the edges, it does not know if the shape is 
actually crossing the edge (It would be too expensive to calculate it anyway). 
So if I expand the bounding, then the relationship must be WITHIN.

Is this assumption not general?

Thanks!




> Polygons with holes don't compute bounds properly in certain situations
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-8063
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8063
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Minor
>         Attachments: LUCENE_8063_fix.patch, LUCENE_8063_test.patch
>
>
> Hi [~daddywri],
> I thought it would be useful to create a random test for bounds. The test 
> have shown problems with polygon with holes. In this ticket I will submit a 
> random test for bounds and propose a fix for bounds for polygons.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to