[ 
https://issues.apache.org/jira/browse/LUCENE-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265058#comment-16265058
 ] 

Ignacio Vera commented on LUCENE-8063:
--------------------------------------

I am not strict enough when building holes, my bad.

I will open a ticket with a patch for the shape generator (I am testing it). 

It seems after the patch that the tests are successful. Do you still think that 
the test is flawed? I actually think it did a pretty good job, e.g. it showed 
that some shapes were wrong.

> Polygons with holes don't compute bounds properly in certain situations
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-8063
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8063
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Minor
>         Attachments: LUCENE_8063_fix.patch, LUCENE_8063_test.patch
>
>
> Hi [~daddywri],
> I thought it would be useful to create a random test for bounds. The test 
> have shown problems with polygon with holes. In this ticket I will submit a 
> random test for bounds and propose a fix for bounds for polygons.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to